debug: close read-only tabs on end debug session

[mohammadamin16]

The issue: #197949.
The issue was that in a debugging session, user could open some read-only files from the test environment, but when the session ended, there was no need to the read-only tabs to stay open, since the user couldn't edit them and it causes frustration for them.
To test it, you can simply start a debug session and open some read-only files from that debugging environment, like the files in the LOADED_SCRIPTS section and end the session, all the tabs that are read only and opened from the debug context should be closed.

[roblourens]

stopSession is called when the user requests to stop the session, but I think this should also happen any time the session stops (like if it stops by itself). So this might be a better place for the code:

vscode/src/vs/workbench/contrib/debug/browser/debugService.ts

Line 699 in 5f86283

this._onDidEndSession.fire(session);

[roblourens]

Also I'm just thinking about whether it would actually be useful to be able to be able to keep these files open in some scenarios where you are actively working with them and don't want to reopen them for each session. But we could add a setting later, if needed.

[mohammadamin16]

@roblourens
I moved the code

[connor4312]

Also I'm just thinking about whether it would actually be useful to be able to be able to keep these files open in some scenarios where you are actively working with them and don't want to reopen them for each session. But we could add a setting later, if needed.

I agree. For example when debugging Node.js things, there are internal scripts that don't exist on disk. One can step into them and e.g. set breakpoints in them between debug sessions. I think this behavior should be under a setting (probably off by default?)

Link to where debug settings are defined:

vscode/src/vs/workbench/contrib/debug/browser/debug.contribution.ts

Line 426 in e97510c

configurationRegistry.registerConfiguration({

[roblourens]

I agree re: disabled by default

[mohammadamin16]

@microsoft-github-policy-service agree

[mohammadamin16]

@connor4312 I added that in the settings.

[connor4312]

I'm not a big fan of this wording, because read-only tabs can come from other places, but I'm not sure how to describe it in a better way without getting superfluous

[connor4312]

We should make sure the source actually came from the debug session that ended as well to avoid closing the wrong things.

There's a getEncodedDebugData on the Source in debugSource.ts that you can use to extract this information from the editor.resource URI.

[connor4312]

one more pertinent comment -- sorry, should have noticed that on the first pass too. Then this should be good 👍

[mohammadamin16]

Thanks for your review @connor4312
I pushed the necessary changes.