fix: accepting terminal completions cursor positions #199706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
Member
Author
|
@Tyriar for review |
Tyriar
requested changes
Dec 1, 2023
src/vs/workbench/contrib/terminal/browser/xterm/suggestAddon.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/xterm/suggestAddon.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/xterm/suggestAddon.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
Tyriar
approved these changes
Dec 7, 2023
lramos15
approved these changes
Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adjusts the cursor positioning when accepting suggestions and improves the disabling behavior of the suggestion modal. It also adjusts the positioning of the suggestion modal when the user is providing input as it currently trails the user's cursor by 1 position.
Testing
Before
before.mp4
After
after.mp4
Part of #154662