Skip to content

fix: memory leak in menu #196302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bpasero merged 2 commits into from
Oct 23, 2023
Merged

fix: memory leak in menu #196302

bpasero merged 2 commits into from
Oct 23, 2023

Conversation

@SimonSiefke
Copy link
Contributor

@SimonSiefke SimonSiefke commented Oct 23, 2023

fixes #195580
@bpasero bpasero self-assigned this Oct 23, 2023
@bpasero bpasero added this to the October 2023 milestone Oct 23, 2023
bpasero
bpasero approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@bpasero bpasero enabled auto-merge (squash) October 23, 2023 18:04
@bpasero bpasero merged commit c51b33b into microsoft:main Oct 23, 2023
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@SimonSiefke @bpasero @Alex0007
fix: memory leak in menu (microsoft#196302)
1032112 
* fix: memory leak in menu

* 💄

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
@brauliobarahona
Copy link

brauliobarahona commented Nov 7, 2023 •
edited
Loading

hallo, VS Code still crashes in Mac OS Sonoma, vscode 1.84.1

➜  ~ code --disable-gpu
➜  ~ code --status     

Version:          Code 1.84.1 (2b35e1e6d88f1ce073683991d1eff5284a32690f, 2023-11-06T12:37:18.666Z)
OS Version:       Darwin x64 23.1.0
CPUs:             Intel(R) Core(TM) i7-8559U CPU @ 2.70GHz (8 x 2700)
Memory (System):  16.00GB (0.35GB free)
Load (avg):       5, 3, 3
VM:               0%
Screen Reader:    no
Process Argv:     --disable-gpu --crash-reporter-id 8fb189c2-2e57-4991-8371-96c8bbddcf37
GPU Status:       2d_canvas:                              unavailable_software
                  canvas_oop_rasterization:               disabled_off
                  direct_rendering_display_compositor:    disabled_off_ok
                  gpu_compositing:                        disabled_software
                  multiple_raster_threads:                enabled_on
                  opengl:                                 disabled_off
                  rasterization:                          disabled_software
                  raw_draw:                               disabled_off_ok
                  video_decode:                           disabled_software
                  video_encode:                           disabled_software
                  vulkan:                                 disabled_off
                  webgl:                                  unavailable_software
                  webgl2:                                 unavailable_software
                  webgpu:                                 unavailable_software

This issue is close but the bug persists: #184542
@rzhao271 rzhao271 mentioned this pull request Nov 7, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants

@SimonSiefke @brauliobarahona @bpasero @rzhao271