Skip to content

Skip regex.replace() cost when there's nothing to replace #194854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joaomoreno merged 3 commits into from
Oct 23, 2023
Merged

Skip regex.replace() cost when there's nothing to replace #194854

joaomoreno merged 3 commits into from
Oct 23, 2023

Conversation

@jruales
Copy link
Contributor

@jruales jruales commented Oct 5, 2023

@jruales jruales mentioned this pull request Oct 5, 2023
Closed
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Oct 5, 2023

FYI @jruales the CI is failing due to formatting issues. I think the issue is that we use tabs in this repo and you used spaces.
@rebornix rebornix assigned joaomoreno and unassigned rebornix Oct 5, 2023
@jruales
Copy link
Contributor Author

jruales commented Oct 5, 2023

@TylerLeonhardt I have fixed the formatting issues
@vscodenpa vscodenpa added this to the October 2023 milestone Oct 6, 2023
@joaomoreno joaomoreno enabled auto-merge (squash) October 23, 2023 14:26
@joaomoreno joaomoreno merged commit c523b5e into microsoft:main Oct 23, 2023
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@jruales @Alex0007
Skip regex.replace() cost when there's nothing to replace (microsoft#…
671a409 
…194854)

* Skip regex.replace() cost when there's nothing to replace

* Change spaces to tabs
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

5 participants

@jruales @TylerLeonhardt @joaomoreno @rebornix @vscodenpa