Skip to content

Conversation

@hsfzxjy
Copy link
Contributor

@hsfzxjy hsfzxjy commented Sep 29, 2023

Fix #190255

The implementation of faster __vsc_escape_value provided by #190899 seems to misbehave on MacOS. After some investigation, the culprit happens to be of two fold:

  1. Different from the Linux version, the od on Mac will print out sequence of spaces at the beginning of each line, causing the previous implementation to produce dangling \x\x\x and further slow down the bash parsing;
  2. Even after the first problem fixed, the od+tr solution on Mac is still much slower than on Linux, when input content size comes to around 6000 (around 12s according to CI testing), due to unknown reason.

Considering both of these, I decide to ditch the od+tr version, and keep only the one with pure bash.

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up!

@Tyriar Tyriar added this to the October 2023 milestone Oct 2, 2023
@Tyriar Tyriar merged commit 2de1a7a into microsoft:main Oct 2, 2023
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
@hsfzxjy hsfzxjy deleted the fix-fast-bash-escape-190255 branch December 5, 2023 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants