Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #190255
The implementation of faster
__vsc_escape_valueprovided by #190899 seems to misbehave on MacOS. After some investigation, the culprit happens to be of two fold:odon Mac will print out sequence of spaces at the beginning of each line, causing the previous implementation to produce dangling\x\x\xand further slow down the bash parsing;od+trsolution on Mac is still much slower than on Linux, when input content size comes to around 6000 (around 12s according to CI testing), due to unknown reason.Considering both of these, I decide to ditch the
od+trversion, and keep only the one with pure bash.