Skip to content

Fixes websocket doesn't handle ping frames correctly #194436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexdima merged 2 commits into from
Sep 29, 2023
Merged

Fixes websocket doesn't handle ping frames correctly #194436

alexdima merged 2 commits into from
Sep 29, 2023

Conversation

@jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Sep 28, 2023

Fixes #194284
@jeanp413 jeanp413 mentioned this pull request Sep 28, 2023
Closed
@roblourens roblourens assigned alexdima and unassigned roblourens Sep 28, 2023
alexdima
alexdima approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you!
@alexdima alexdima added this to the October 2023 milestone Sep 29, 2023
@alexdima alexdima merged commit d79823e into microsoft:main Sep 29, 2023
@jeanp413 jeanp413 deleted the fix-194284 branch September 29, 2023 16:25
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@alexdima @Alex0007
Merge pull request microsoft#194436 from jeanp413/fix-194284
991a5da 
Fixes websocket doesn't handle ping frames correctly
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants

@jeanp413 @jrieken @alexdima @roblourens