fix: do not set this._sequence to undefined if path title not windows path #193232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikoRaisanen
force-pushed
the
fix-bash-title-windows
branch
from
451d62e to
dc18e09
Compare
…ows path Co-authored-by: Noel Abrahams <NoelAbrahams@users.noreply.github.com>
NikoRaisanen
force-pushed
the
fix-bash-title-windows
branch
from
dc18e09 to
257869b
Compare
Tyriar
approved these changes
Sep 16, 2023
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Thanks for looking into this 👍
DonJayamanne
approved these changes
Sep 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #192771
GitBash and WSL terminal titles can now be changed from the cli.
Previously, the title would not change unless it was a Windows path