Skip to content

Detect more scoop git bash paths #192085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lszomoru merged 1 commit into from
Sep 4, 2023
Merged

Detect more scoop git bash paths #192085

lszomoru merged 1 commit into from
Sep 4, 2023

Conversation

@wickles
Copy link
Contributor

@wickles wickles commented Sep 3, 2023

Fixes #192084
@lszomoru lszomoru requested a review from Tyriar September 4, 2023 07:36
@lszomoru
Copy link
Member

lszomoru commented Sep 4, 2023

This looks good to me but I want to make sure that @Tyriar takes a look as well.
Tyriar
Tyriar approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lszomoru yep looks good, since we're dealing with executables we need to be careful about the path, but that's fine as it's in UserProfile.
@Tyriar Tyriar added this to the September 2023 milestone Sep 4, 2023
@lszomoru lszomoru merged commit 5e0bc19 into microsoft:main Sep 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants

@wickles @lszomoru @Tyriar @aeschli