Fixed import paths not being updated when multiple files are moved #191403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not being updated when multiple files were moved.
Contributor
Author
|
@microsoft-github-policy-service agree |
mjbvz
requested changes
Sep 5, 2023
extensions/typescript-language-features/src/languageFeatures/updatePathsOnRename.ts
Outdated
Show resolved
Hide resolved
|
why closed? is merged into main? |
Contributor
Author
nope |
Collaborator
|
@sbmelvin Why did you close it then? |
Contributor
Author
|
I generally don't keep PRs open for longer than two weeks. The PR stalled so I closed it. |
Collaborator
|
Please reopen it. There’s plenty of reasons PRs may take longer than 2weeks, such an upcoming release blocking merging or as other work priories coming up |
Contributor
Author
sure |
Contributor
Author
|
@mjbvz The PR checks say changes were requested but I'm unsure how to resolve them. I've changed the |
mjbvz
approved these changes
Sep 13, 2023
DonJayamanne
approved these changes
Sep 13, 2023
lins0621
pushed a commit
to lins0621/vscode
that referenced
this pull request
Sep 14, 2023
…icrosoft#191403) * Modified updatePathsOnRename.ts to fix issue where import paths were not being updated when multiple files were moved. * Removed errant console log * Changed return statements to continue in for-of loop --------- Co-authored-by: Stephen Melvin <steve.melvin@dtn.com>
|
Thank you |
hhc87
pushed a commit
to lins0621/vscode
that referenced
this pull request
Oct 8, 2023
…icrosoft#191403) * Modified updatePathsOnRename.ts to fix issue where import paths were not being updated when multiple files were moved. * Removed errant console log * Changed return statements to continue in for-of loop --------- Co-authored-by: Stephen Melvin <steve.melvin@dtn.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105110
Modified updatePathsOnRename.ts to fix an issue where import paths were not being updated when multiple files are moved.