Skip to content

Find with selected values when reveal TerminalFind #190466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tyriar merged 2 commits into from
Aug 16, 2023
Merged

Find with selected values when reveal TerminalFind #190466

Tyriar merged 2 commits into from
Aug 16, 2023

Conversation

@tisilent
Copy link
Contributor

@tisilent tisilent commented Aug 15, 2023

fix #189343
@tisilent
Find with selected values when
69adc1f 
reveal TerminalFind
meganrogge
meganrogge previously approved these changes Aug 15, 2023
View reviewed changes
meganrogge
meganrogge reviewed Aug 15, 2023
View reviewed changes
src/vs/workbench/contrib/terminalContrib/find/browser/terminalFindWidget.ts Outdated
const initialInput = this._instance.hasSelection() && !this._instance.selection!.includes('\n') ? this._instance.selection : undefined;
const xterm = this._instance.xterm;
if (xterm && this.inputValue && this.inputValue !== '') {
if (xterm && initialInput && initialInput !== '') {
Copy link
Contributor

@meganrogge meganrogge Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to fallback to this.inputValue if initialInput is undefined?
Copy link
Contributor Author

@tisilent tisilent Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to adjust and test it.
connor4312
connor4312 previously approved these changes Aug 15, 2023
View reviewed changes
@meganrogge meganrogge requested a review from Tyriar August 15, 2023 17:14
@tisilent
fallback to this.inputValue if
004189e 
 initialInput is undefined
@tisilent tisilent dismissed stale reviews from connor4312 and meganrogge via 004189e August 16, 2023 09:16
@tisilent
Copy link
Contributor Author

tisilent commented Aug 16, 2023

hi @meganrogge , fallback to this.inputValue, It can improve the following operating experience.

  1. reveal
  2. hide
  3. input command
  4. reveal
@Tyriar Tyriar added this to the August 2023 milestone Aug 16, 2023
Tyriar
Tyriar approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks again @tisilent 👏
@Tyriar Tyriar enabled auto-merge August 16, 2023 14:55
@Tyriar Tyriar merged commit d4e89fd into microsoft:main Aug 16, 2023
@tisilent tisilent deleted the fix-terminalFinad-initial-search branch August 16, 2023 15:59
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

5 participants

@tisilent @Tyriar @connor4312 @TylerLeonhardt @meganrogge