Add "Peek Call Hierarchy" and "Peek Type Hierarchy" actions to Command Palette #189607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #186399
Changes
f1: trueoption to the creation of "Peek Call Hierarchy" and "Peek Type Hierarchy" actions, which inherits fromEditorAction2class and adds the action to Command Palette.PeekCallHierarchyActionandPeekTypeHierarchyActionin order to align with other actions defined insrc/vs/editor/contrib/gotoSymbol/browser/goToCommands.ts, e.g.PeekDefinitionActionAdditional info
I could already see "Peek Call Hierarchy" action in local Code - OSS with this change. However I still could not see "Peek Type Hierarchy" action because the built-in languages services don't seem to provide a single type hierarchy provider. So I couldn't verify that my edit in
PeekTypeHierarchyActionworks. Please give me a hint in how to verify it if it's necessary.