Fix Terminals aren't persisting anymore #183516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
previously approved these changes
May 26, 2023
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
@meganrogge LGTM if it's working for you, I haven't tested
Contributor
|
Thanks @jeanp413 for looking into this! Your fix works 🎉 , but some terminal API tests are failing at the moment. Rerunning to see if it was just a flake |
Contributor
|
They're only failing on windows, which is odd |
Contributor
Author
|
@meganrogge should work now 🙂 |
meganrogge
approved these changes
May 27, 2023
TylerLeonhardt
approved these changes
May 27, 2023
Contributor
|
I was stumped by this one @jeanp413. thank you again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183445