Fix a task startup race #180546
Merged
Fix a task startup race #180546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@meganrogge I found this issue while trying to debug #180243. |
meganrogge
reviewed
May 4, 2023
Fixes microsoft#180541 The fix is to enforce `instanceLimit` even when there is no entry in `_activeTasks`. Once that's done, microsoft#165560 is no longer needed - and is in fact harmful, since it can incorrectly prevent re-launching a task whose `instanceLimit` is greater than one.
markw65
force-pushed
the
in-progress-tasks-fix
branch
from
d3a1f08 to
acbd63f
Compare
Tyriar
approved these changes
May 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #180541
The fix is to enforce
instanceLimiteven when there is no entry in_activeTasks. Once that's done, #165560 is no longer needed - and is in fact harmful, since it can incorrectly prevent re-launching a task whoseinstanceLimitis greater than one.