Skip to content

Conversation

@bitekas
Copy link
Contributor

@bitekas bitekas commented Apr 15, 2023

This PR fixes the onDidClose code example.

The current example has a compilcation failure with the error:

[{
	"resource": "extension.ts",
	"owner": "typescript",
	"code": "2322",
	"severity": 8,
	"message": "Type 'Event<TerminalDimensions>' is not assignable to type 'Event<number | void>'.\n  Type 'TerminalDimensions' is not assignable to type 'number | void'.",
	"source": "ts",
	"startLineNumber": 25,
	"startColumn": 4,
	"endLineNumber": 25,
	"endColumn": 14,
	"relatedInformation": [
		{
			"startLineNumber": 11075,
			"startColumn": 3,
			"endLineNumber": 11075,
			"endColumn": 13,
			"message": "The expected type comes from property 'onDidClose' which is declared here on type 'Pseudoterminal'",
			"resource": "node_modules/@types/vscode/index.d.ts"
		}
	]
}]
@meganrogge meganrogge requested a review from Tyriar May 1, 2023 17:20
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Tyriar Tyriar added this to the May 2023 milestone May 1, 2023
@Tyriar Tyriar enabled auto-merge May 1, 2023 18:32
@Tyriar Tyriar closed this May 2, 2023
auto-merge was automatically disabled May 2, 2023 21:55

Pull request was closed

@Tyriar Tyriar reopened this May 2, 2023
@Tyriar Tyriar enabled auto-merge May 2, 2023 21:56
@Tyriar Tyriar merged commit ad55a4c into microsoft:main May 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants