Skip to content

Conversation

@dan-petty
Copy link
Contributor

Fix paths misconfigured if build-in profile with same name exists

@dan-petty
Copy link
Contributor Author

@dan-petty dan-petty closed this Feb 26, 2023
@dan-petty dan-petty reopened this Feb 26, 2023
@dan-petty
Copy link
Contributor Author

@microsoft-github-policy-service agree

@dan-petty
Copy link
Contributor Author

To test set a custom path for "Git Bash" profile in settings.json:

    "terminal.integrated.profiles.windows": {
        "Git Bash": {
            "path": "C:\\custom\\path\\to\\git\\bin\\bash.exe"
        }
    }
@dan-petty dan-petty changed the title Update terminalProfiles.ts Feb 26, 2023
@rzhao271 rzhao271 assigned meganrogge and unassigned rzhao271 Feb 27, 2023
@Tyriar Tyriar self-assigned this Mar 29, 2023
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a little trouble reproducing, I think because the git bash source picks up my install, but this fix looks good and safe 👍

@Tyriar Tyriar added this to the April 2023 milestone Mar 29, 2023
@Tyriar Tyriar enabled auto-merge March 29, 2023 16:00
@meganrogge meganrogge modified the milestones: April 2023, May 2023 Apr 21, 2023
@Tyriar Tyriar closed this May 2, 2023
auto-merge was automatically disabled May 2, 2023 21:56

Pull request was closed

@Tyriar Tyriar reopened this May 2, 2023
@Tyriar Tyriar enabled auto-merge May 2, 2023 21:56
@Tyriar Tyriar merged commit f4329b3 into microsoft:main May 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

5 participants