Skip to content

Conversation

@keerthivasansa
Copy link
Contributor

@keerthivasansa keerthivasansa commented Feb 22, 2023

Fixes #173866

Changes

  • Registered Workbench actions to toggle the Fuzzy Search behaviour in the Explorer Search Menu.
  • The actions can be mapped to keyboard shortcuts hence allowing the user to create a keyboard shortcut to toggle or switch to a specific find match type.
  • The registered actions are:
    - Explorer: Toggle Find Match Type
    - Explorer: Switch to Fuzzy Find Match Type
    - Explorer: Switch to Contagious Find Match Type

Technical Changes

  • Since the other commands in command palette are associated with focusing on views, no separate actions file was present for explorer category. Thus, I have created explorerActions.ts in vs/base/browser/actions/explorerActions.ts and registered the actions in it.
  • A getter and setter for findMatchType was required in AsyncDataTree for this to be modified from an action. Async Data Tree was modified accordingly.
@keerthivasansa
Copy link
Contributor Author

@microsoft-github-policy-service agree

keerthivasansa and others added 5 commits February 23, 2023 09:38
Contiguous Spelled wrong

Co-authored-by: John Murray <johnm@georgejames.com>
Co-authored-by: John Murray <johnm@georgejames.com>
Co-authored-by: John Murray <johnm@georgejames.com>
@joaomoreno joaomoreno added this to the March 2023 milestone Feb 23, 2023
@joaomoreno joaomoreno changed the title Workbench actions for Explorer Fuzzy Search Toggle Feb 23, 2023
Copy link
Contributor Author

@keerthivasansa keerthivasansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes made in the latest commit.

@keerthivasansa
Copy link
Contributor Author

Hi @joaomoreno, I think it's ready for re-review. I have made the requested changes in 3443042
Please have a look and let me know if everything looks good or any other changes are required.

@joaomoreno joaomoreno modified the milestones: March 2023, April 2023 Mar 20, 2023
@sandy081 sandy081 modified the milestones: April 2023, May 2023 Apr 26, 2023
@joaomoreno joaomoreno removed this from the May 2023 milestone May 28, 2023
@keerthivasansa
Copy link
Contributor Author

@gjsjohnmurray @joaomoreno Are there any pending changes that I have to implement to close this?

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs reviews by team members, and I am not one. Pinging @joaomoreno

@joaomoreno joaomoreno added this to the December / January 2024 milestone Dec 19, 2023
@joaomoreno joaomoreno added the tree-widget Tree widget issues label Dec 19, 2023
@joaomoreno
Copy link
Member

Thanks for your contribution! I have simplified it to become a simple toggle. 🍻

@joaomoreno joaomoreno enabled auto-merge (squash) December 19, 2023 15:41
@joaomoreno joaomoreno merged commit 48996f7 into microsoft:main Dec 19, 2023
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tree-widget Tree widget issues

5 participants