Skip to content

Conversation

@jeanp413
Copy link
Contributor

This PR fixes #137568

@weinand weinand assigned joaomoreno and unassigned weinand Nov 22, 2021
@joaomoreno joaomoreno assigned alexdima and unassigned joaomoreno Nov 22, 2021
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjbvz @joaomoreno The suggested change looks good to me, but I would like to get approval from you as well. Here is what I can put together:

  • yarn extensions-ci is executed in the compilation phase
  • extensions-ci is a gulp task that executes both compileExtensionsBuildTask and compileExtensionMediaBuildTask
  • in gulpfile.vscode.reh.js, we would be calling in 1 place compileExtensionsBuildTask but not compileExtensionMediaBuildTask
  • similarly, in gulpfile.vscode.js we would be calling in 3 places compileExtensionsBuildTask, but not compileExtensionMediaBuildTask
  • this PR adds compileExtensionMediaBuildTask in 2 of the 4 places where compileExtensionsBuildTask was called

I plan that gulpfile.vscode.reh.js should do exactly what gulpfile.vscode.js does. So in this particular case, although issue #137568 talks about missing files in the server build, it looks like those files would be missing also in the vscode build (unless someone manually runs extensions-ci before).

I will therefore defer to you @joaomoreno @mjbvz to figure out what you want to do here and I am happy to take whatever you do also in gulpfile.reh.js.

@alexdima alexdima requested review from joaomoreno and mjbvz November 22, 2021 14:26
@alexdima alexdima assigned joaomoreno and unassigned alexdima Nov 22, 2021
@alexdima alexdima added the engineering VS Code - Build / issue tracking / etc. label Nov 22, 2021
@joaomoreno
Copy link
Member

Thanks for the investigation @alexdima. This is the correct change. The changes in gulpfile.vscode.js should've been made at the time compileExtensionMediaBuildTask was introduced.

The *-ci tasks are running only in our CI which is orchestrated in a way that extensions-ci is always going to be called before vscode-*-ci.

@joaomoreno
Copy link
Member

joaomoreno commented Nov 24, 2021

Thanks @jeanp413 🚀

@joaomoreno joaomoreno merged commit 556ce85 into microsoft:main Nov 24, 2021
@jeanp413 jeanp413 deleted the fix-137568 branch November 24, 2021 14:32
guibber pushed a commit to guibber/vscode that referenced this pull request Nov 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

engineering VS Code - Build / issue tracking / etc.

5 participants