Skip to content

Conversation

@alex-brs
Copy link
Contributor

@alex-brs alex-brs commented Nov 9, 2021

This PR fixes #136789

Change proposes to make the error message of build/npm/preinstall.js match the actual conditional before it. Assumes the conditional in the code takes precedence over the error message.

Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jrieken jrieken added this to the November 2021 milestone Nov 10, 2021
@jrieken jrieken merged commit 654829a into microsoft:main Nov 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants