#fix: 108459 #108666
Merged
#fix: 108459 #108666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the widget is usually referred to as the "Find Widget" - see https://code.visualstudio.com/docs/editor/codebasics#_find-and-replace - for the description and name in the PR. |
update: add 'findInSelection' argument update: 'Search Widget' --> 'Find Widget'
Contributor
Author
|
@ArturoDent Thanks for pointing out! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #108459
arguments type is same with
INewFindReplaceStatealthough JSON schema is little different.It excludes
searchScope(It's not a primitive) andloop(It's only for internal state)Unlike SearchEditor, arguments cannot include variables since it's an editor-scoped, not a workbench-scoped.