Fix Copy GitHub Permalink with custom SSH #6669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianvuerings
force-pushed
the
fix-custom-ssh-copy-github-permalink
branch
from
bab3f07 to
e82bfaa
Compare
| } | ||
| // upstream's origin by ssh | ||
| if (fetchUrl.startsWith('git@') && !fetchUrl.startsWith('git@github.com')) { | ||
| if ((fetchUrl.startsWith('git@') || fetchUrl.includes('@git')) && !fetchUrl.startsWith('git@github.com')) { |
Contributor
Author
There was a problem hiding this comment.
Issue was that we would only match git@git.musta.ch:organization/repo.git, not org-4@git.musta.ch:organization/repo.git
Open to other suggestions as well - e.g. matching .endsWith('.git') instead
Member
There was a problem hiding this comment.
Seems like a reasonable heuristic to me!
Contributor
Author
|
@microsoft-github-policy-service agree |
joaomoreno
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6668