Skip to content

Add a refresh button in the header of comment thread #5229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexr00 merged 1 commit into from
Sep 12, 2023
Merged

Add a refresh button in the header of comment thread #5229

alexr00 merged 1 commit into from
Sep 12, 2023

Conversation

@hsfzxjy
Copy link
Contributor

@hsfzxjy hsfzxjy commented Sep 8, 2023

fix #5161
@hsfzxjy hsfzxjy force-pushed the update-comment-button-5161 branch from 0ee944a to 48d8ae6 Compare September 8, 2023 03:21
alexr00
alexr00 requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have one comment.
package.json Outdated
Copy link
Member

@alexr00 alexr00 Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order here seems wrong. I would keep this before the collapse action.

image
Copy link
Contributor Author

@hsfzxjy hsfzxjy Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've adjusted it!
Copy link
Member

@alexr00 alexr00 Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order is determined by the group, not by the position in the package.json.
Copy link
Contributor Author

@hsfzxjy hsfzxjy Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I've fixed it now.
@hsfzxjy hsfzxjy force-pushed the update-comment-button-5161 branch from 48d8ae6 to e67bf59 Compare September 8, 2023 15:26
alexr00
alexr00 requested changes Sep 11, 2023
View reviewed changes
package.json Outdated
Copy link
Member

@alexr00 alexr00 Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order is determined by the group, not by the position in the package.json.
@hsfzxjy hsfzxjy force-pushed the update-comment-button-5161 branch from e67bf59 to fff1b2f Compare September 12, 2023 05:32
alexr00
alexr00 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!
@alexr00 alexr00 enabled auto-merge (squash) September 12, 2023 10:04
@alexr00 alexr00 added this to the September 2023 milestone Sep 12, 2023
@alexr00 alexr00 merged commit 346f8e0 into microsoft:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@hsfzxjy @aeschli @alexr00