Skip to content

Conversation

@taisph
Copy link
Contributor

@taisph taisph commented Nov 5, 2021

If an issue name contains parenthesis characters, they are currently
added to the generated branch name, causing bash to complain about the
name if it is not quoted.

I.e. git checkout test/some(other)branch
bash: syntax error near unexpected token `('

Stripping the parenthesis characters from the branch name fixes this.

If an issue name contains parenthesis characters, they are currently
added to the generated branch name, causing bash to complain about the
name if it is not quoted.

I.e. `git checkout test/some(other)branch`
bash: syntax error near unexpected token `('

Stripping the parenthesis characters from the branch name fixes this.
@taisph taisph marked this pull request as ready for review November 5, 2021 12:34
@alexr00 alexr00 added this to the November 2021 milestone Nov 8, 2021
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@alexr00 alexr00 merged commit 70496a1 into microsoft:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants