Skip to content

Round progress percentage according to the spec #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbaeumer merged 1 commit into from
Jan 31, 2024
Merged

Round progress percentage according to the spec #1413

dbaeumer merged 1 commit into from
Jan 31, 2024

Conversation

@w0rm
Copy link
Contributor

@w0rm w0rm commented Jan 29, 2024

Closes #1412
@w0rm
Copy link
Contributor Author

w0rm commented Jan 29, 2024

@microsoft-github-policy-service agree
dbaeumer
dbaeumer requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@dbaeumer dbaeumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments about the tests.
@dbaeumer
Copy link
Member

dbaeumer commented Jan 30, 2024

and thanks a lot for the PR.
@w0rm w0rm force-pushed the round-progress-percentage branch from ab0ffad to cd14443 Compare January 30, 2024 11:01
@w0rm
Copy link
Contributor Author

w0rm commented Jan 30, 2024 •
edited
Loading

@dbaeumer thanks for the review, I've created a separate test and added the comment.
@w0rm w0rm force-pushed the round-progress-percentage branch from cd14443 to de7873f Compare January 30, 2024 15:00
@dbaeumer dbaeumer enabled auto-merge (squash) January 31, 2024 08:57
@vscodenpa vscodenpa added this to the February 2024 milestone Jan 31, 2024
@dbaeumer dbaeumer merged commit 295aaa3 into microsoft:main Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@w0rm @dbaeumer @aeschli @vscodenpa