Skip to content

Conversation

@Cecil0o0
Copy link
Contributor

Inside "API" outline, "LANGUAGE EXTENSIONS" section, "Overview" article, there is a paragraph on the top.

I was puzzled with sentence "VS Code doesn't provide built-in language support", because we have multiple language extension inside "extensions" at the root of VS Code codebase.

If I'm right, this pr would like to fix it to make this sentence clear~

@ntrogh
Copy link
Contributor

ntrogh commented Oct 14, 2024

@Cecil0o0 Thanks for pointing out this confusion. I've suggested a modification to your PR to make sure it's technically correct.

@Cecil0o0
Copy link
Contributor Author

@ntrogh would you please describe more for me to work it out about the modification to "make sure it’s technically correct"?

I might not understand for now, that is to say, how could I make a modification to verify "technically correct"?

@ntrogh
Copy link
Contributor

ntrogh commented Oct 15, 2024

@Cecil0o0 I've added a suggestion in the review comments to make the text correct.
Your edit mentioned that VS Code provides built-in language support, which is not the case. Everything is handled by extensions. And some of those extensions are bundled with the editor.

@Cecil0o0
Copy link
Contributor Author

@ntrogh I try to modify my edit for technically correct as well as fix of confusion.

In my opinion, I think this "VS Code" points to "workbench" which means src/vs/code and without extensions, for not introducing more complexity, I consider to reuse "extensions" word instead of "workbench" to represent same means. I don't know if it is a native-like style representation that I try to imitate.

@ntrogh
Copy link
Contributor

ntrogh commented Oct 15, 2024

@Cecil0o0 I already added a suggestion for you to commit. You can just scroll up and commit my suggestion.

@Cecil0o0
Copy link
Contributor Author

@ntrogh 😂 I would like to commit your suggestion but I couldn't see it even if scroll up, I don't know what happen and how to deal with it

image

Copy link
Contributor

@ntrogh ntrogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've re-added the text suggestion.

Co-authored-by: Nick Trogh <1908215+ntrogh@users.noreply.github.com>
@Cecil0o0 Cecil0o0 changed the title does provide built-in language support. Oct 15, 2024
Copy link
Contributor

@ntrogh ntrogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @Cecil0o0 !

@ntrogh ntrogh merged commit 84073e7 into microsoft:main Oct 15, 2024
@vs-code-engineering vs-code-engineering bot added this to the October 2024 milestone Oct 15, 2024
@Cecil0o0 Cecil0o0 deleted the built-in-language branch October 15, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants