-
Notifications
You must be signed in to change notification settings - Fork 5.5k
doesn't provide built-in language support in the core editor #7679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Cecil0o0 Thanks for pointing out this confusion. I've suggested a modification to your PR to make sure it's technically correct. |
|
@ntrogh would you please describe more for me to work it out about the modification to "make sure it’s technically correct"? I might not understand for now, that is to say, how could I make a modification to verify "technically correct"? |
|
@Cecil0o0 I've added a suggestion in the review comments to make the text correct. |
1890425 to
3fbb031
Compare
|
@ntrogh I try to modify my edit for technically correct as well as fix of confusion. In my opinion, I think this "VS Code" points to "workbench" which means |
|
@Cecil0o0 I already added a suggestion for you to commit. You can just scroll up and commit my suggestion. |
|
@ntrogh 😂 I would like to commit your suggestion but I couldn't see it even if scroll up, I don't know what happen and how to deal with it |
ntrogh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've re-added the text suggestion.
Co-authored-by: Nick Trogh <1908215+ntrogh@users.noreply.github.com>
ntrogh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing, @Cecil0o0 !

Inside "API" outline, "LANGUAGE EXTENSIONS" section, "Overview" article, there is a paragraph on the top.
I was puzzled with sentence "VS Code doesn't provide built-in language support", because we have multiple language extension inside "extensions" at the root of VS Code codebase.
If I'm right, this pr would like to fix it to make this sentence clear~