Skip to content

Conversation

Signed-off-by: Odin Dahlström <zerodind@gmail.com>
@ntrogh ntrogh requested a review from nickzhums September 6, 2024 09:25
@ntrogh
Copy link
Contributor

ntrogh commented Sep 6, 2024

@0dinD thanks for updating our docs.

@nickzhums can you review these changes?

@ntrogh ntrogh added the java label Sep 6, 2024
@nickzhums
Copy link
Member

@jdneo @testforstephen Could you please help take a look at the proposed changes? I think we do support JDK 1.5 or above, so need you guys to double check

@jdneo
Copy link
Member

jdneo commented Sep 9, 2024

@nickzhums, start from 1.33.0 the minimum supported jdk version changes to 1.8

eclipse-jdtls/eclipse.jdt.ls#3227

Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @0dinD thanks for contribution.

@ntrogh ntrogh merged commit ae5830c into microsoft:main Sep 9, 2024
@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants