Skip to content

Add command executor abstraction, only run dotnet CLI tests on CI #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
connor4312 merged 1 commit into from
Aug 18, 2025
Merged

Add command executor abstraction, only run dotnet CLI tests on CI #607

connor4312 merged 1 commit into from
Aug 18, 2025

Conversation

@joelverhagen
Copy link
Contributor

@joelverhagen joelverhagen commented Aug 14, 2025 •
edited
Loading

Address microsoft/vscode#261524.
Improve test coverage with IFetcherService in nuget.ts.

Uses CI + BUILD_ARTIFACTSTAGINGDIRECTORY similar to

vscode-copilot-chat/src/util/vs/base/common/platform.ts

Line 82 in e42aea6

_isCI = !!nodeProcess.env['CI'] || !!nodeProcess.env['BUILD_ARTIFACTSTAGINGDIRECTORY'];

@joelverhagen
Copy link
Contributor Author

joelverhagen commented Aug 18, 2025

@connor4312 - is this one you would like to review?
connor4312
connor4312 approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@connor4312 connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
@connor4312 connor4312 enabled auto-merge August 18, 2025 23:07
@vs-code-engineering vs-code-engineering bot added this to the August 2025 milestone Aug 18, 2025
@connor4312 connor4312 added this pull request to the merge queue Aug 18, 2025
Merged via the queue into microsoft:main with commit 3d74f45 Aug 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage-needed

4 participants

@joelverhagen @DonJayamanne @connor4312 @hediet