Add message length events to MSFT internal telemetry #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Aug 6, 2025
| export function sendEngineMessagesTelemetry(telemetryService: ITelemetryService, messages: CAPIChatMessage[], telemetryData: TelemetryData) { | ||
| export function sendEngineMessagesLengthTelemetry(telemetryService: ITelemetryService, messages: CAPIChatMessage[], telemetryData: TelemetryData, logService?: ILogService) { | ||
| // Determine if this is input or output based on message characteristics | ||
| const isOutput = messages.length === 1 && messages[0].role === 'assistant'; |
Member
There was a problem hiding this comment.
Instead of trying to guess this from the input would it be easier to just pass a flag as a parameter or something?
roblourens
approved these changes
Aug 7, 2025
DonJayamanne
approved these changes
Aug 7, 2025
roblourens
reviewed
Aug 8, 2025
| messages: messagesWithLength | ||
| }; | ||
| logService?.info(`[TELEMETRY] engine.messages.length: ${JSON.stringify(logData, null, 2)}`); | ||
| logService?.debug(`[TELEMETRY] engine.messages.length: ${JSON.stringify(logData, null, 2)}`); |
Member
There was a problem hiding this comment.
This is kind of noisy, why do you need to log it?
pierceboggan
pushed a commit
that referenced
this pull request
Aug 11, 2025
* add length telemetry event with log message * convert function arguments to length * add completionId * remove tokens * add modelCallId * fix modelCallId * fix modelCallId * move modelCallId from inside messages * add type guard for 'tool_calls' * add curly brackets * remove duplicate noChoice * use isOutput instead of guessing input/output * fix usage issue * change logging to debug mode --------- Co-authored-by: Yevhen Mohylevskyy <yevhenmohylevskyy@Yevhens-MacBook-Pro.local> Co-authored-by: Yevhen Mohylevskyy <yevhenmohylevskyy@mac.lan>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a telemetry event that would have a similar structure as engine.messages events but with content replaced by length of that content. This way the messages will be much shorter, not truncated, les likely to drop, and will allow to compute input cost of each tool - total number of characters contributed by a tool to all the conversation input messages it is included in.