Fix deprecated command highlighting for variable names in CMake syntax #4673
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes visible behavior
The CMake syntax highlighter was flagging
SOURCE_FILESand other deprecated command names as invalid even when used as variable names:The following changes are proposed:
^\s*\b) instead of matching anywhere (\b), consistent with how regular commands are matched (lines 33-37, 42-43)The purpose of this change
Deprecated CMake commands (
SOURCE_FILES,BUILD_NAME,VTK_WRAP_*, etc.) from CMake 1.x should only be flagged when used as commands at line start, not when used as variable names or in expansions like${SOURCE_FILES}.Pattern change:
Other Notes/Information
TextMate grammar change only—no code impact. Variable names can be arbitrary; using
SOURCE_FILESas a variable is valid CMake.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
2wrvsblobprodwus2180.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/yarn install(dns block)40vvsblobprodwus2135.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/yarn install(dns block)b15vsblobprodwus2164.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/yarn install(dns block)b53vsblobprodwus2154.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/yarn install(dns block)d94vsblobprodwus2119.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/yarn install(dns block)k4pvsblobprodwus2140.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/yarn install(dns block)n6wvsblobprodwus2123.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/yarn install(dns block)p2tvsblobprodwus2189.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/yarn install(dns block)v41vsblobprodwus2175.vsblob.vsassets.io/usr/local/bin/node node /usr/local/bin/yarn install(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This section details on the original issue you should resolve
<issue_title>[Bug] Odd
SOURCE_FILESvariable highlighting?</issue_title><issue_description>### Brief Issue Summary
SOURCE_FILESseems to have a special highlighting - e.g. see the snippet below.Is it a bug? Highlighting looks like there was some kind of syntax issue but there isn't.
CMake Tools Diagnostics
{ "os": "win32", "vscodeVersion": "1.107.0-insider", "cmtVersion": "1.21.36", "configurations": [ { "folder": "l:\\Projects\\Github\\test", "cmakeVersion": "unknown", "configured": false, "generator": "unknown", "usesPresets": false, "compilers": {} } ], "cpptoolsIntegration": { "isReady": false, "hasCodeModel": false, "activeBuildType": "", "buildTypesSeen": [], "requests": [], "responses": [], "partialMatches": [], "targetCount": 0, "executablesCount": 0, "librariesCount": 0, "targets": [] }, "settings": [ { "communicationMode": "automatic", "useCMakePresets": "auto", "configureOnOpen": true } ] }Debug Log
.Additional Information
No response</issue_description>
<agent_instructions>You are Copilot coding agent acting as a senior maintainer/contributor for the VS Code extension repository microsoft/vscode-cmake-tools.
You are deeply familiar with CMake, CMake Presets, CTest, kit/toolchain selection, VS Code extension APIs, and the architecture of this repo (TypeScript-heavy).
Your job is to resolve the GitHub issue provided below safely and in a maintainable way, matching existing patterns and UX.
SOURCE OF TRUTH
[Bug] Odd
SOURCE_FILESvariable highlighting? #4613 - Bug [Bug] OddSOURCE_FILESvariable highlighting? #4613NON-NEGOTIABLE PROCESS
Automated:
Targeted scenario verificatio...
SOURCE_FILESvariable highlighting? #4613✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.