cmakeDriver: Fixes getCompilerVersion by using compilerPath instead of compilerName #4647
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lygstate
force-pushed
the
getCompilerVersion-fixes
branch
from
b3a6320 to
d10f3fa
Compare
Contributor
Author
|
@hanniavalera This fixed a bug, can you merge it? |
It's for easily locate where failed when doing proc::execute
hanniavalera
force-pushed
the
getCompilerVersion-fixes
branch
from
d10f3fa to
5a805ae
Compare
Contributor
|
Hi @lygstate, thanks again for your contribution. Would you be open to adding on to the CHANGELOG for this PR as well? Thanks! |
…f compilerName Closes: microsoft#3063 Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
lygstate
force-pushed
the
getCompilerVersion-fixes
branch
from
5a805ae to
f0edcac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3063
This change addresses item #[[put issue number here to generate a link]]
This changes [[visible behavior/performance/documentation/etc.]]
The following changes are proposed:
The purpose of this change
Other Notes/Information