Fix tab row acrylic material in unfocused windows #19647
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the issue where the tab row loses its acrylic material when the window loses focus, even when 'Allow acrylic material in unfocused windows' setting is enabled. The fix modifies the _updateThemeColors() function in TerminalPage.cpp to check both the UseAcrylicInTabRow setting AND the window focus state along with the EnableUnfocusedAcrylic setting. Now the tab row will maintain its acrylic effect when: 1. UseAcrylicInTabRow is enabled, AND 2. Either the window is focused OR EnableUnfocusedAcrylic is enabled This ensures that the 'Allow acrylic material in unfocused windows' setting is properly respected for the tab row, not just the terminal background. Fixes microsoft#19544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes tab row losing acrylic material when window is unfocused, even when "Allow acrylic material in unfocused windows" is enabled.
References
Fixes #19544
Changes
Modified
_updateThemeColors()inTerminalPage.cppto check both window focus state andEnableUnfocusedAcrylicsetting.Testing