Fix logic that touches registry to be very robust #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to install a .NET Profiler via the registry for some PerfView operations. We were not being agressive enough to clean up even, if things are partly wrong. This can leave stale state behind. This improves the robustness.
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
+ Coverage 17.53% 17.53% +<.01%
==========================================
Files 213 213
Lines 122865 122876 +11
Branches 11837 11837
==========================================
+ Hits 21541 21544 +3
- Misses 100465 100474 +9
+ Partials 859 858 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
+ Coverage 17.53% 17.53% +<.01%
==========================================
Files 213 213
Lines 122865 122876 +11
Branches 11837 11837
==========================================
+ Hits 21541 21544 +3
- Misses 100465 100474 +9
+ Partials 859 858 -1
Continue to review full report at Codecov.
|
vancem
added a commit
that referenced
this pull request
Dec 19, 2017
Fix logic that touches registry to be very robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to install a .NET Profiler via the registry for some PerfView operations.
We were not being agressive enough to clean up even, if things are partly wrong.
This can leave stale state behind. This improves the robustness.