-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Refatorar(devcontainer): Simplificar o ambiente de desenvolvimento pa… #7089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ra ser apenas Python Remove as dependências e configurações do .NET do ambiente de desenvolvimento do Docker. - Simplifica o `devcontainer.json` para remover as features do .NET, Azure e as extensões do VS Code relacionadas. - Simplifica o `startup.sh` para remover os comandos de configuração do .NET. Isso cria um ambiente de desenvolvimento mais leve e focado para desenvolvedores Python e permite que o contâiner seja construído e executado diretamente com os comandos do `docker-compose`.
|
@hebenezer-m please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies the development container environment by removing all .NET dependencies and configurations, focusing exclusively on Python development. This change creates a lighter, more focused development environment for Python developers.
Key changes:
- Removed standalone workflow files for Redis memory and Mem0 tests, consolidating them into the main checks workflow
- Eliminated .NET SDK, Azure CLI, and related VS Code extensions from the devcontainer
- Removed .NET-specific setup commands from the startup script
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/python-package-0.2.yml | Deleted workflow file for AgentChat 0.2 PyPI package deployment |
| .github/workflows/pytest-redis-memory.yml | Deleted standalone Redis memory tests workflow |
| .github/workflows/pytest-mem0.yml | Deleted standalone Mem0 memory tests workflow |
| .github/workflows/checks.yml | Added consolidated test-mem0 and test-redis-memory jobs to main checks workflow |
| .devcontainer/startup.sh | Removed .NET workload and certificate setup commands |
| .devcontainer/devcontainer.json | Removed .NET, Azure, and Aspire devcontainer features and VS Code extensions |
| --health-start-period 30s | ||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@v4 |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checkout action version differs from the deleted workflow files. The deleted workflows used actions/checkout@v3, but this uses @v4. While using the newer version is acceptable, ensure this version is consistent with other jobs in this workflow file for maintainability.
| uses: actions/checkout@v4 | |
| uses: actions/checkout@v3 |
| cd python/packages/autogen-ext | ||
| pytest --cov=autogen_ext.memory.mem0 tests/memory/test_mem0.py -v --cov-report=xml | ||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v5 |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ra ser apenas Python
Remove as dependências e configurações do .NET do ambiente de desenvolvimento do Docker.
devcontainer.jsonpara remover as features do .NET, Azure e as extensões do VS Code relacionadas.startup.shpara remover os comandos de configuração do .NET.Isso cria um ambiente de desenvolvimento mais leve e focado para desenvolvedores Python e permite que o contâiner seja construído e executado diretamente com os comandos do
docker-compose.Why are these changes needed?
Related issue number
Checks