Optimize the selection NextSpeaker mechanism of RolePlayOrchestrator … #6688
+108
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to improve the accuracy of name hits Improvement content: 1. Enforce the use of the JSON standard return format. 2. Introduce a one-time retry mechanism to reduce the error rate (currently, all tests pass 100%).
…to improve the accuracy of name hits Improvement content: 1. Enforce the use of the JSON standard return format. 2. Introduce a one-time retry mechanism to reduce the error rate (currently, all tests pass 100%).
…to improve the accuracy of name hits
| var name = response.GetContent() ?? throw new ArgumentException("No name is returned."); | ||
| var responseMessageStr = response.GetContent() ?? throw new ArgumentException("No name is returned."); | ||
|
|
||
| RolePlayOrchestratorResponse? responseMessage; |
Collaborator
There was a problem hiding this comment.
nit:
var responseMessage = JsonSerializer.Deserialize<RolePlayOrchestratorResponse>(responseMessageStr) ?? throw new InvalidOperationException("Incorrect RolePlayOrchestratorResponse JSON format.");
|
|
||
| var reaginCandidate = candidates.FirstOrDefault(x => x.Name!.ToUpper() == regainResponseMessage.Speaker!.ToUpper()); | ||
|
|
||
| if (reaginCandidate != null) |
Collaborator
There was a problem hiding this comment.
reaginCandidate -> regainCadidate
| namespace AutoGen.Core.Orchestrator; | ||
| internal class RolePlayOrchestratorResponse | ||
| { | ||
| internal string? Speaker { get; set; } |
Collaborator
There was a problem hiding this comment.
The access modifier of property doesn't have to be also internal here?
Contributor
Author
There was a problem hiding this comment.
public is also fine.
| Each message will start with 'From name:', e.g: | ||
| From {agentNames.First()}: | ||
| //your message//."); | ||
| ## Available Speaker Names |
Collaborator
There was a problem hiding this comment.
Maybe adding a class-level summary on top?
/// <summary>
/// This orchestrator uses a robust two-step strategy to select the next speaker in a roleplay conversation:
/// 1. It first prompts the LLM to select the next speaker from the list of valid candidate names, requiring output in a strict JSON format.
/// 2. If the LLM's chosen name does not exactly match any candidate (e.g., due to hallucination, abbreviation, or formatting issues),
/// the orchestrator issues a second prompt to the LLM, instructing it to map the provided name to the closest valid candidate name from the original list.
/// This approach ensures that the selected speaker always corresponds to an authorized candidate and guards against LLM output errors.
/// </summary>
LittleLittleCloud
requested changes
Jun 17, 2025
Collaborator
LittleLittleCloud
left a comment
LittleLittleCloud
left a comment
There was a problem hiding this comment.
PR LGTM, minor changes requested before merging
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6688 +/- ##
=======================================
Coverage 79.71% 79.71%
=======================================
Files 232 232
Lines 17323 17323
=======================================
Hits 13809 13809
Misses 3514 3514
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to improve the accuracy of name hits
Improvement content:
Checks