[ci] Move check-docs and lint jobs off Travis #3726
Conversation
StrikerRUS
left a comment
StrikerRUS
left a comment
There was a problem hiding this comment.
Thanks for doing this! Please check some my initial comments below:
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
… ci/lint-and-docs
|
ok I think this is ready for another review |
StrikerRUS
left a comment
StrikerRUS
left a comment
There was a problem hiding this comment.
Generally this R looks OK to me. Thanks! Please check one more round of review below:
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
… ci/lint-and-docs
StrikerRUS
left a comment
StrikerRUS
left a comment
There was a problem hiding this comment.
Great! Thank you for reorganizing CI!
I even had a chance to test rerun-all button for new workflow - Wikipedia was not answering. Everything was OK.
Just two nits.
| export OS_NAME="linux" | ||
| export COMPILER="gcc" |
There was a problem hiding this comment.
I think we can move these variables to env section of this config file closer to PYTHON_VERSION and other constants.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
* [ci] move CI jobs from Travis to Azure DevOps (fixes #3519) * comment out other CIs to avoid wasting cycles * try without docker * add container back * stop using --user in pip install * run check-docs and lint without container * job names * move more jobs to Azure-hosted Linux pool * fix PATH for check-docs * uncomment other CI * uncomment windows * remove uses of maxParallel * try moving macos-latest jobs to GitHub Actions * fix config * fix missing conda env * set Python version * remove commented-out code * add more to GitHub Actions * try to fix GPU * remove static_analysis to prevent conflicts with #3726 * change workflow name * try using ubuntu:latest docker * fix conda * trying to find where permissions first break * add workaround for sudo * please azure please * image syntax * more sudo * noninteractive * LC_ALL * more sudo * more stuff * CONDA dir * paths * get path * missing CONDA * fix path stuff * more tests * fix graphviz * stuff * more graphviz * install xorg-libxau * graphviz works, run more jobs * stuff * enable more tests * uncomment GitHub Actions * uncomment all other CIs * Apply suggestions from code review Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * add travis.yml to Rbuildignore * add Rbuildignore rule for fmt * add libomp for clang builds * changes from code review Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Because of #3519 , we're in the process of removing all CI jobs that run on Travis and moving them to GitHub Actions.
This PR moves
check-docsandlintto GitHub Actions. I wanted to do this one by itself to make #3672 smaller. These two jobs are also the easiest to move.This PR proposes putting
check-docsandlintinto a separate GitHub Actions workflow called "Static Analysis". Today, GitHub Actions does not allow you to re-run individual failed jobs. So if one job fails for random or temporary reasons, you have to re-run all jobs in the workflow. Since thecheck-docstasks fails somewhat regularly due to temporary network problems, I think it is a good idea to keep it +lintseparate, so that the cost of re-running it is low.Thanks for reviewing all of these @StrikerRUS . I know it's a lot of PRs but hopefully the end result will be that our CI is more stable.