Fix(MemoryTrunk.DefragTwoRegion): Unsigned difference expression compared to zero #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphEngine/src/Trinity.C/src/Storage/MemoryTrunk/MemoryTrunk.DefragTwoRegion.cpp
Line 43 in e3c0e19
Fix the issue the result of the subtraction
hole_right_offset - _bwd_cell_offset - _bwd_cell_size
should be cast to a signed type (e.g.,int64_t
) before performing the comparison. This ensures that the subtraction can produce negative values, and the comparison> 0
will behave as intended.Steps to fix:
int64_t
before performing the comparison.