fix #263 #265
Merged
fix #263 #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaobin
reviewed
Jan 4, 2019
| @@ -96,7 +96,7 @@ namespace Trinity | |||
| } | |||
| bool Read(char* buffer, int32_t start, int32_t count) | |||
| { | |||
| return (count == fread(buffer + start, count, 1, fp)); | |||
| return (1 == fread(buffer + start, count, 1, fp)); | |||
There was a problem hiding this comment.
The parameter name 'count' is confusing. It may be better to rename it to 'element_size' or just 'size' to be consistent with fread()'s parameter name. For the reference, here is the prototype of fread: size_t fread(void *ptr, size_t size, size_t nmemb, FILE *stream).
There was a problem hiding this comment.
sure, we'd better say size instead of count -- fool me once
shaobin
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.