Fix: Support attach configurations for coreclr debugger #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
startDebuggingmethod indebuggingExecutor.tsassumes allcoreclrconfigurations have aprogramproperty. However, attach configurations useprocessNameorprocessIdinstead ofprogram.This causes the extension to crash with:
When trying to use attach configurations like:
{ "name": "Attach to Process", "type": "coreclr", "request": "attach", "processName": "MyApp.exe" }Solution
Added a check for
config.request !== 'attach'to skip the special coreclr test handling for attach configurations. This allows attach configurations to correctly usevscode.debug.startDebugging().Testing
processNameparameterChanges
src/debuggingExecutor.ts: Added condition to exclude attach requests from special coreclr handling