Skip to content

Skip lambda allocation in 'EventSourceCache' #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sergio0694 merged 2 commits into from
Apr 12, 2025
Merged

Skip lambda allocation in 'EventSourceCache' #1977

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85f0bc2
Skip lambda allocation in 'EventSourceCache'
Sergio0694 Apr 10, 2025
a330f05
Add comment
Sergio0694 Apr 10, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/WinRT.Runtime/Interop/EventSourceCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,17 @@ public static void Create(IObjectReference obj, int index, global::System.WeakRe
cachesLock.EnterReadLock();
try
{
#if NET
caches.AddOrUpdate(
key: obj.ThisPtr,
addValueFactory: static (IntPtr ThisPtr, CachesFactoryArgs args) => new EventSourceCache(args.Target, args.Index, args.State),
updateValueFactory: static (IntPtr ThisPtr, EventSourceCache cache, CachesFactoryArgs args) => cache.Update(args.Target, args.Index, args.State),
factoryArgument: new CachesFactoryArgs(target, index, state));
#else
caches.AddOrUpdate(obj.ThisPtr,
(IntPtr ThisPtr) => new EventSourceCache(target, index, state),
(IntPtr ThisPtr, EventSourceCache cache) => cache.Update(target, index, state));
#endif
}
finally
{
Expand Down Expand Up @@ -147,5 +155,21 @@ public static void Remove(IntPtr thisPtr, int index, global::System.WeakReferenc
}
}
}

#if NET
// We're intentionally using a separate type and not a value tuple, because creating generic
// type instantiations with this type when delegates are involved results in additional
// metadata being preserved after trimming. This can save a few KBs in binary size on Native AOT.
// See: https://github.com/dotnet/runtime/pull/111204#issuecomment-2599397292.
private readonly struct CachesFactoryArgs(
global::WinRT.Interop.IWeakReference target,
int index,
global::System.WeakReference<object> state)
{
public readonly global::WinRT.Interop.IWeakReference Target = target;
public readonly int Index = index;
public readonly global::System.WeakReference<object> State = state;
}
#endif
}
}
Loading