Add fallback code for managed vtables for skia scenarios#1819
Merged
manodasanW merged 1 commit intomasterfrom Oct 10, 2024
Merged
Add fallback code for managed vtables for skia scenarios#1819manodasanW merged 1 commit intomasterfrom
manodasanW merged 1 commit intomasterfrom
Conversation
Sergio0694
approved these changes
Oct 10, 2024
Member
Author
|
Confirmed fix with repro. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects using Skia seem to be hitting our restriction on managed vftbl types that we had put given we couldn't guarantee trimming compat and all generated managed vftbl were in the Windows SDK projection which was updated alongside the change. But Skia happened to have a manual projection with a managed vftbl and given folks are running into this, adding fallback code to handle it.
dotnet/maui#25150
#1645