Fix issue where RuntimeClassName for boxed type object was empty string#1548
Merged
manodasanW merged 2 commits intomasterfrom Mar 22, 2024
Merged
Fix issue where RuntimeClassName for boxed type object was empty string#1548manodasanW merged 2 commits intomasterfrom
manodasanW merged 2 commits intomasterfrom
Conversation
jlaanstra
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If someone called GetRuntimeClassName on a boxed type object, they previously got empty string. This was because we saw the type as
System.RuntimeTypeand didn't recognize that as a WinRT type. This addresses it by checking for if the object derives from type and if so, returns the runtime class name for type.