Add option to disable localized exception messages#1447
Merged
Sergio0694 merged 3 commits intostaging/AOTfrom Jan 24, 2024
Merged
Add option to disable localized exception messages#1447Sergio0694 merged 3 commits intostaging/AOTfrom
Sergio0694 merged 3 commits intostaging/AOTfrom
Conversation
Member
Author
|
Saves 142 KB on .NET 9!! 🎉
|
Base automatically changed from
user/sergiopedri/feature-switches
to
staging/AOT
January 17, 2024 11:50
Sergio0694
force-pushed
the
user/sergiopedri/resource-key-switch
branch
from
f860801 to
fa42a26
Compare
manodasanW
reviewed
Jan 23, 2024
manodasanW
approved these changes
Jan 24, 2024
Sergio0694
added a commit
that referenced
this pull request
Jan 24, 2024
* Update WinRTRuntimeErrorStrings to be handwritten * Add FeatureSwitches.UseExceptionResourceKeys * Trim localized resources from ILLink.Substitutions.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #1435 and adds an option to disable localized exception messages, matching what the runtime also does when setting the
UseSystemResourceKeysfeature switch. The new flag allows trimming all of CsWinRT's embedded resources.