Move generic delegates vtable generation into projections#1411
Merged
manodasanW merged 7 commits intostaging/AOTfrom Dec 16, 2023
Merged
Move generic delegates vtable generation into projections#1411manodasanW merged 7 commits intostaging/AOTfrom
manodasanW merged 7 commits intostaging/AOTfrom
Conversation
…r than lookup table.
… delegates when the generic is known.
vineeththomasalex
approved these changes
Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the previous AOT changes, the generic delegate vtable generation was handled by the AOT optimizer using a lookup table. But this turned out that each of the projections got a lookup table when that wasn't the intention as it is supposed to be for consumers of projections. This lookup table in projections also made those types not trimming friendly. Given delegates have a known set of interfaces that they implement unlike classes which needs to deal with covariance, this PR moves the delegate vtable generation into the projection.
With this PR, when a delegate is being used by a projection, it would make sure the generic instantiation class for the delegate has been initialized and its vtable entries have been added so that on lookup they are found. The AOT optimizer will continue to handle cases where delegates are passed as object and the projection isn't aware of that.