Use hardcoded IIDs for all well known IReferenceArray<T> types#1402
Merged
Sergio0694 merged 3 commits intostaging/AOTfrom Dec 1, 2023
Merged
Use hardcoded IIDs for all well known IReferenceArray<T> types#1402Sergio0694 merged 3 commits intostaging/AOTfrom
Sergio0694 merged 3 commits intostaging/AOTfrom
Conversation
Sergio0694
force-pushed
the
dev/reference-array-iids
branch
from
4ec5601 to
75cb090
Compare
Sergio0694
commented
Dec 1, 2023
| @@ -776,135 +776,135 @@ private static ComInterfaceEntry ProvideIReferenceArray(Type arrayType) | |||
| { | |||
Member
Author
There was a problem hiding this comment.
There's also some whitespace normalization.
REVIEW WITH SHOW WHITESPACE OFF
jlaanstra
approved these changes
Dec 1, 2023
manodasanW
reviewed
Dec 1, 2023
manodasanW
approved these changes
Dec 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds precomputed IIDs to
InterfaceIIDsfor all well knownIReferenceArray<T>types used inComWrappersSupport, and replaces all calls toGuidGenerator.GetIIDwith these constants. Couldn't remove all the additional cruft inIReferenceArray<T>yet because there's the generic path that's still using that, but this is a step in the right direction. We'll have to revisit that later anyway given it's 100% not AOT compatible (due toMakeGenericType).