Skip to content

Remove Resurrect logic as it shouldn't be needed for .NET 6 and newer.#1380

Merged
manodasanW merged 3 commits intomicrosoft:masterfrom
jlaanstra:user/jlaans/remove-resurrect
Jan 25, 2024
Merged

Remove Resurrect logic as it shouldn't be needed for .NET 6 and newer.#1380
manodasanW merged 3 commits intomicrosoft:masterfrom
jlaanstra:user/jlaans/remove-resurrect

Conversation

@jlaanstra
Copy link
Collaborator

@jlaanstra jlaanstra commented Nov 11, 2023

After talking with @manodasanW we should no longer need Resurrect on .NET 6 and newer.

@jlaanstra jlaanstra marked this pull request as ready for review November 11, 2023 04:50
@jlaanstra jlaanstra requested a review from manodasanW November 30, 2023 22:35
@jlaanstra jlaanstra changed the base branch from staging/AOT to master January 2, 2024 17:18
@jlaanstra jlaanstra force-pushed the user/jlaans/remove-resurrect branch from d5b7249 to 9d04677 Compare January 2, 2024 17:21
@jlaanstra jlaanstra requested a review from Sergio0694 January 8, 2024 19:16
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@jlaanstra jlaanstra force-pushed the user/jlaans/remove-resurrect branch from 7c9fe67 to 52a3feb Compare January 25, 2024 03:19
@manodasanW
Copy link
Member

Confirmed using both .NET 6 and .NET 8 with the old repro app that this change runs without issue.

@manodasanW manodasanW merged commit 70e9541 into microsoft:master Jan 25, 2024
Sergio0694 pushed a commit that referenced this pull request Jan 25, 2024
#1380)

* Remove Resurrect logic as it shouldn't be needed for .NET 6 and newer.

* Remove double check.

* Add check back.
Sergio0694 added a commit that referenced this pull request Jan 26, 2024
#1380) (#1469)

* Remove Resurrect logic as it shouldn't be needed for .NET 6 and newer.

* Remove double check.

* Add check back.

Co-authored-by: Johan Laanstra <jlaans@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants