Handle field names with non alphanumeric characters #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When supplying a payload of {"-1":"Fails"} the fieldname will be 1.
This will fail when running gofmt(and is not a valid go identifier).
This change checks if the sanitized field name is a number. If so it will preprend Num.
To avoid duplicate field names because of sanitizing values the code now keeps a map with used
fields for the current struct.
mholt
approved these changes
Sep 17, 2021
pincher95
added a commit
to pincher95/json-to-go
that referenced
this pull request
Oct 20, 2021
Handle field names with non alphanumeric characters (mholt#99)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using gerrit code review which used this in the json of the rest api:
{"-1":"Fails"}. This fails the gofmt as it results in a numeric field name.This change checks if the sanitized field name is a number. If so it will preprend Num.
To avoid duplicate field names because of sanitizing values the code now keeps a map with used
fields for the current struct.