fix special-case NotImplementedType in binop signatures to match runtime semantics #1129

crates/pyrefly_bundled/third_party/stubs/sympy-stubs/polys/matrices/domainmatrix.pyi

@@ -62,8 +62,8 @@ class DomainMatrix:
     def hstack(A, *B) -> DomainMatrix: ...
     def vstack(A, *B) -> DomainMatrix: ...
     def applyfunc(self, func, domain=...) -> Self: ...
-    def __add__(A, B) -> NotImplementedType: ...
-    def __sub__(A, B) -> NotImplementedType: ...
+    def __add__(A, B) -> Self | NotImplementedType: ...
+    def __sub__(A, B) -> Self | NotImplementedType: ...
     def __neg__(A) -> Self: ...
     def __mul__(A, B) -> DomainMatrix | Self | NotImplementedType: ...
     def __rmul__(A, B) -> DomainMatrix | Self | NotImplementedType: ...
@@ -77,7 +77,7 @@ class DomainMatrix:
     def scalarmul(A, lamda) -> DomainMatrix | Self: ...
     def rscalarmul(A, lamda) -> DomainMatrix | Self: ...
     def mul_elementwise(A, B) -> Self: ...
-    def __truediv__(A, lamda) -> NotImplementedType: ...
+    def __truediv__(A, lamda) -> Self | NotImplementedType: ...
     def pow(A, n) -> Self: ...
     def scc(self) -> list[Any]: ...
     def rref(self) -> tuple[Self, tuple[Any, ...]]: ...

crates/pyrefly_bundled/third_party/stubs/sympy-stubs/polys/rings.pyi

@@ -132,17 +132,17 @@ class PolyElement(DomainElement, DefaultPrinting, CantSympify, dict):
     def __add__(p1, p2) -> Self | PolyElement | NotImplementedType: ...
     def __radd__(p1, n) -> Self | NotImplementedType: ...
     def __sub__(p1, p2) -> Self | NotImplementedType: ...
-    def __rsub__(p1, n) -> NotImplementedType: ...
-    def __mul__(p1, p2) -> NotImplementedType: ...
-    def __rmul__(p1, p2) -> NotImplementedType: ...
+    def __rsub__(p1, n) -> Self | NotImplementedType: ...
+    def __mul__(p1, p2) -> Self | PolyElement | NotImplementedType: ...
+    def __rmul__(p1, p2) -> Self | NotImplementedType: ...
     def __pow__(self, n) -> Self: ...
     def square(self): ...
     def __divmod__(p1, p2) -> tuple[Any, Any] | tuple[list[Any], Any] | NotImplementedType | tuple[Self, Self]: ...
-    def __rdivmod__(p1, p2) -> NotImplementedType: ...
+    def __rdivmod__(p1, p2) -> tuple[Self, Self] | NotImplementedType: ...
     def __mod__(p1, p2) -> NotImplementedType | Self: ...
-    def __rmod__(p1, p2) -> NotImplementedType: ...
+    def __rmod__(p1, p2) -> Self | NotImplementedType: ...
     def __truediv__(p1, p2) -> list[Any] | NotImplementedType | Self: ...
-    def __rtruediv__(p1, p2) -> NotImplementedType: ...
+    def __rtruediv__(p1, p2) -> Self | NotImplementedType: ...
 
     __floordiv__ = ...
     __rfloordiv__ = ...

crates/pyrefly_python/src/dunder.rs

@@ -202,8 +202,8 @@ pub fn rich_comparison_fallback(op: CmpOp) -> Option<Name> {
     let name = match op {
         CmpOp::Lt => GT,
         CmpOp::LtE => GE,
-        CmpOp::Eq => NE,
-        CmpOp::NotEq => EQ,
+        CmpOp::Eq => EQ,
+        CmpOp::NotEq => NE,
         CmpOp::Gt => LT,
         CmpOp::GtE => LE,
         _ => return None,