Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pyrefly/lib/alt/class/class_field.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4235,6 +4235,20 @@ impl<'ctx, 'answer, Ans: LookupAnswer> AnswersSolver<'ctx, 'answer, Ans> {
{
return;
}
if field_name != &dunder::INIT_SUBCLASS
&& (class_field.is_abstract() || self.get_metadata_for_class(cls).is_protocol())
&& class_field
.ty()
.toplevel_func_metadata()
.is_some_and(|meta| {
matches!(
meta.flags.body_kind,
BodyKind::Ellipsis | BodyKind::Trivial | BodyKind::RaiseNotImplementedError
)
})
{
return;
}
// If any base derives from `Any`, we can't reliably tell whether the method
// overrides a concrete parent method, so suppress the check. Gather this
// across all bases first so the decision is independent of base order.
Expand Down
51 changes: 51 additions & 0 deletions pyrefly/lib/test/class_overrides.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2449,6 +2449,57 @@ class MultipleInheritance(AbstractBase, ConcreteBase):
"#,
);

testcase!(
test_missing_super_call_abstract_or_protocol_child,
TestEnv::new().enable_missing_super_call_error(),
r#"
from abc import ABC, abstractmethod
from typing import Protocol

class Base:
def __init__(self, x: int) -> None:
self.x = x

class AbstractChildEllipsis(Base, ABC):
@abstractmethod
def __init__(self, x: int, y: int) -> None:
...

class AbstractChildPass(Base, ABC):
@abstractmethod
def __init__(self, x: int, y: int) -> None:
pass

class AbstractChildRaise(Base, ABC):
@abstractmethod
def __init__(self, x: int, y: int) -> None:
raise NotImplementedError

class ParentProto(Protocol):
x: int
def __init__(self, x: int) -> None:
self.x = x

class SubProto(ParentProto, Protocol):
def __init__(self, x: int, y: int) -> None:
...

registry: list[type] = []

class Registered(Protocol):
def __init_subclass__(cls) -> None:
super().__init_subclass__()
registry.append(cls)

class SubProtoInitSubclass(Registered, Protocol):
def __init_subclass__(cls) -> None: # E: Method `SubProtoInitSubclass.__init_subclass__` does not call the method of the same name in a parent class
...

class Impl(SubProtoInitSubclass):
pass
"#,
);

testcase!(
test_override_descriptor_method,
r#"
Expand Down
Loading