Repository navigation
Conversation
The errors option described severity values in its intro but its Type line said boolean only. The parser also accepts the severity strings error, warn, info, hint and ignore, so list them in the Type line and add a note with an example.
|
✅ This PR meets all requirements from our pull request checklist. Note: this comment updates automatically after changes to the PR. Updates may take up to half an hour. |
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D128766108. (Because this pull request was imported automatically, there will not be any future comments.) |
Contributor
|
This looks good to me. Unfortunately I can't merge it right away - it accidentally got imported before the CLA was signed, which (for reasons involving internal tooling) means I need a stamp from a teammate. Hopefully we'll get it merged in the next couple of days |
rchen152
approved these changes
Nov 1, 2026
rchen152
left a comment
rchen152
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
errorsoption intro says each error kind takes a severity, but its Type line says "boolean representing enabled status". The parser (crates/pyrefly_config/src/error.rs) acceptserror,warn,info,hintandignoreas strings as well as booleans.This lists the severity strings in the Type line and adds a note with an example (
bad-return = "warn").Fixes #5418
Test Plan
Docs-only change. Ran
python3 test.py --no-test --no-tensor-shapes --no-conformance --no-jsonschema --no-extension(passes). Also ranpyrefly checkwith[errors] bad-return = "warn": the error is reported as a warning, not an error.I am new to open source, and this pull request was made with AI assistance.