Repository navigation
fix Pyrefly extension not supported for VSCode "browser" mode (vscode.dev) #2240 - #5446
Open
asukaminato0721 wants to merge 6 commits into
Open
asukaminato0721 wants to merge 6 commits into
asukaminato0721 wants to merge 6 commits into
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D128251235. (Because this pull request was imported automatically, there will not be any future comments.) |
This comment has been minimized.
This comment has been minimized.
Browser builds cannot use the native filesystem URL conversion. Encode virtual POSIX paths as file URIs and retain native conversion on desktop targets.
Browser clients need cross-file locations, LSP completion edits, and import requests that do not depend on diagnostic text. Extend the in-memory APIs while retaining the existing playground interface. Use the Rust TOML parser and preserve the session Python version when configuration has no version. Cover these contracts with Rust tests.
Publish hashes after both generated artifacts are complete. Consumers can reject stale bindings instead of combining incompatible builds. Allow builds without the optional binary optimization step.
Add a browser entry point and worker backed by the WASM APIs. Read dependencies through the host filesystem service without scanning the workspace. Isolate workspace state and retain original document URIs while converting protocol positions to UTF-16. Bundle validated WASM inputs in normal and watch builds. Keep browser types separate from desktop types and provide a web launch task.
Exercise the real worker and WASM bundle to detect protocol, Unicode, workspace isolation, import lifecycle, and version regressions. Check matching assets in normal and watch builds. Validate VSIX contents and run language-client conversion and completion acceptance in a real browser host.
Generate WASM inputs before packaging so release artifacts include a usable browser server. Validate the browser VSIX and run its host test in CI. Document local builds, test commands, and support boundaries.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2240
continue of #2460
Test Plan
add test