Repository navigation
[Nexthop][m4340nhp] Fill the local DSF node MAC from the chassis EEPROM at boot - #1881
Open
marif-nexthop wants to merge 2 commits into
Open
marif-nexthop wants to merge 2 commits into
marif-nexthop wants to merge 2 commits into
Conversation
2 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
On a VOQ switch, the agent requires a
nodeMacon its owndsfNodesentry and stops at config load without one. A platform's defaultagent.confis shared by every unit, so it cannot carry that per-unit MAC. Whenfboss_init.shcreatesagent.conf, it now runs the newset_dsf_node_mac.py, which writes the chassis EEPROM'sSwitch ASIC MAC Baseinto each localdsfNodesentry without anodeMac, and into the matchingswitchMacwhen that is unset too. The script reads theCHASSIS_EEPROM_PARSEDfile that platform_manager writes. Configs without a local DSF node are left unchanged, and an existingagent.confis never rewritten.Test Plan
On a
m4340nhpdevice without anagent.conf,fboss_initcreates one with the unit's MAC asnodeMacandswitchMac, and the agents start and bring up all 64 front-panel ports. A second run leaves the file unchanged, and the script leaves an NPU config untouched.